[ovs-dev] [PATCH v2 0/2] flow dumps containing igmp match cannot be restored

Salvatore Daniele sdaniele at redhat.com
Tue Jul 20 19:50:28 UTC 2021


match_format() prints the keyword "igmp" for flows with the field
"ip,nw_proto=2". ofp_parse_protocol does not accept this value.

This results in flow dump restoration failing when the ovs-save script
is used by "ovs-ctl restart" on a dump of flows containing this match.
However, removing the "igmp" keyword entirely could break existing
scripts in stable branches.

The first patch addresses this issue by providing a workaround within
ovs-save to preserve the 'igmp' keyword while allowing flows to be
restored. This change would be backported to all stable branches.

The second patch removes this workaround, and removes the 'igmp' output
entirely, replacing it with 'ip,nw_proto=2'. This has been added to
NEWS, and would be applied in master branch only.

v2
- Address comments made of v1 with regard to a work around for stable
  branches

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1982743

Signed-off-by: Salvatore Daniele <sdaniele at redhat.com>
Signed-off-by: Adrian Moreno <amorenoz at redhat.com>
Co-authored-by: Adrian Moreno <amorenoz at redhat.com>

Adrian Moreno (1):
  Match: Do not print "igmp" match keyword

Salvatore Daniele (1):
  ovs-save: Save igmp flows in ofp_parse syntax

 NEWS               | 2 ++
 lib/match.c        | 2 --
 tests/ovs-ofctl.at | 6 ++++++
 3 files changed, 8 insertions(+), 2 deletions(-)

-- 
2.31.1



More information about the dev mailing list