[ovs-dev] [PATCH v2 ovn] northd: do not centralized traffic for unclaimed virtual ports

[Dumitru Ceara]

On 6/22/21 2:47 PM, Lorenzo Bianconi wrote:
> Add a rule to drop traffic from a distributed NAT if the virtual
> port has not claimed yet becaused otherwise the traffic will be
> centralized misconfiguring the TOR switch.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1952961
> 
> Co-authored-by: Numan Siddique <numans at ovn.org>
> Signed-off-by: Numan Siddique <numans at ovn.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi at redhat.com>
> ---

Hi Lorenzo,

Unfortunately this patch needs a small rebase (some rather easy to fix
conflicts in ovn-northd.c).

[...]

> diff --git a/northd/ovn_northd.dl b/northd/ovn_northd.dl
> index 3afa80a3b..08faf5da6 100644
> --- a/northd/ovn_northd.dl
> +++ b/northd/ovn_northd.dl
> @@ -5555,6 +5555,10 @@ for (rp in &RouterPort(.router = &Router{._uuid = lr_uuid, .options = lr_options
>      }
>  }
>  
> +relation NATForVirtualLogicalPort(logical_port: Option<string>)
> +NATForVirtualLogicalPort(Some{logical_port}) :-
> +    lsp in &nb::Logical_Switch_Port(.name = logical_port, .__type = "virtual").
> +

A minor comment is that I would call this relation 'VirtualLogicalPort'
instead of 'NATForVirtualLogicalPort' because it's populated regardless
of NAT being configured or not and may be used in the future for other
types of rules.

With that addressed, please go ahead and add my ack to the rebased v3:

Acked-by: Dumitru Ceara <dceara at redhat.com>

Regards,
Dumitru