[ovs-dev] [PATCH ovn v2 1/5] controller: Move 'struct local_datapath' to a separate file.

Numan Siddique numans at ovn.org
Tue Jul 27 02:38:51 UTC 2021


On Mon, Jul 26, 2021 at 10:04 PM Han Zhou <zhouhan at gmail.com> wrote:
>
> On Mon, Jul 26, 2021 at 6:47 PM Han Zhou <zhouhan at gmail.com> wrote:
> >
> >
> >
> > On Fri, Jul 16, 2021 at 4:45 AM <numans at ovn.org> wrote:
> > >
> > > From: Numan Siddique <numans at ovn.org>
> > >
> > > This would uncomplicate the binding.c code a bit.  The tracking
> > > data and the related functions are also moved to the file - ldata.h.
> > > This would help in an upcoming patch.
> > >
>
> Hi Numan,
>
> Sorry that one more comment regarding the new module "ldata" naming. It is
> a little confusing to me. Maybe it is supposed to take care of local
> bindings? Would local_binding be better? "l" can mean logical, local or
> something else.

Hi Han,

I supposed to mean "local data".  I thought naming "local_binding.c"
or "lbinding.c" would
be confusing since we already have binding.c

My idea was for this file to be used for maintaining local data and
not just binding.

Does "local_data.c" seem fine to you ?


Regarding your comment on "has_local_l3gateway" in the previous reply,
 you're right.
I'll handle that in v2.

Thanks for the reviews.

Numan


>
> Thanks,
> Han
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list