[ovs-dev] [PATCH] dpif-netdev: Fix non-atomic read of smc_enable_db.

Eelco Chaudron echaudro at redhat.com
Tue Jul 27 13:49:45 UTC 2021



On 23 Jul 2021, at 23:11, Ilya Maximets wrote:

> Atomic variables must be read atomically.  And since we already have
> 'smc_enable_db' in the PMD context, we need to use it from there to
> avoid reading atomically twice.
>
> Also, 'smc_enable_db' is a global configuration, there is no need
> to read it per-port or per-rxq.
>
> CC: Harry van Haaren <harry.van.haaren at intel.com>
> Fixes: 9ac84a1a3698 ("dpif-avx512: Add ISA implementation of dpif.")
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>

Changes look good to me.

Acked-by: Eelco Chaudron <echaudro at redhat.com>



More information about the dev mailing list