[ovs-dev] [PATCH ovn] binding: Log when all LSP related flows have been installed.

Dumitru Ceara dceara at redhat.com
Wed Jul 28 10:28:31 UTC 2021


Currently ovn-controller logs (at level INFO) when a logical switch
port claimed or released but we have no default logs about when its
corresponding openflows have been successfully installed.  This commit
adds such logs.

Signed-off-by: Dumitru Ceara <dceara at redhat.com>
---
 controller/binding.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/controller/binding.c b/controller/binding.c
index d50f3affa..bb64d3451 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -823,12 +823,15 @@ local_binding_set_up(struct shash *local_bindings, const char *pb_name,
     if (!ovs_readonly && lbinding && lbinding->iface
             && !smap_get_bool(&lbinding->iface->external_ids,
                               OVN_INSTALLED_EXT_ID, false)) {
+        VLOG_INFO("Setting lport %s ovn-installed in OVS", pb_name);
         ovsrec_interface_update_external_ids_setkey(lbinding->iface,
                                                     OVN_INSTALLED_EXT_ID,
                                                     "true");
     }
 
-    if (!sb_readonly && lbinding && b_lport && b_lport->pb->n_up) {
+    if (!sb_readonly && lbinding && b_lport && b_lport->pb->n_up
+            && !b_lport->pb->up[0]) {
+        VLOG_INFO("Setting lport %s up in Southbound", pb_name);
         binding_lport_set_up(b_lport, sb_readonly);
         LIST_FOR_EACH (b_lport, list_node, &lbinding->binding_lports) {
             binding_lport_set_up(b_lport, sb_readonly);
@@ -847,11 +850,13 @@ local_binding_set_down(struct shash *local_bindings, const char *pb_name,
     if (!ovs_readonly && lbinding && lbinding->iface
             && smap_get_bool(&lbinding->iface->external_ids,
                              OVN_INSTALLED_EXT_ID, false)) {
+        VLOG_INFO("Removing lport %s ovn-installed in OVS", pb_name);
         ovsrec_interface_update_external_ids_delkey(lbinding->iface,
                                                     OVN_INSTALLED_EXT_ID);
     }
 
-    if (!sb_readonly && b_lport && b_lport->pb->n_up) {
+    if (!sb_readonly && b_lport && b_lport->pb->n_up && b_lport->pb->up[0]) {
+        VLOG_INFO("Setting lport %s down in Southbound", pb_name);
         binding_lport_set_down(b_lport, sb_readonly);
         LIST_FOR_EACH (b_lport, list_node, &lbinding->binding_lports) {
             binding_lport_set_down(b_lport, sb_readonly);
-- 
2.27.0



More information about the dev mailing list