[ovs-dev] [PATCH ovn v2] ovs: Include monitor condition expected seqno fix.

Numan Siddique numans at ovn.org
Tue Jun 1 11:48:17 UTC 2021


On Thu, May 20, 2021 at 10:27 AM Ilya Maximets <i.maximets at ovn.org> wrote:
>
> On 5/18/21 8:49 AM, Dumitru Ceara wrote:
> > When setting monitor conditions ovsdb_cs_db_set_condition() returns the
> > sequence number when it is expected that all updates that correspond to
> > the new condition have been received.  This sequence number is used by
> > ovn-controller to determine whether a monitor condition change is
> > already in flight.  If that's the case ovn-controller waits until all
> > in-flight condition changes have been processed before propagating the
> > SB_Global.nb_cfg value to the chassis record.
> >
> > This is part of the "ovn-nbctl --wait=hv sync" implementation which, as
> > far as I know, is not used actively by any CMS but is, however, used by
> > OVN self tests.
> >
> > Bump the OVS submodule version to include b5bb044fbe4c ("ovsdb-cs:
> > Consider all tables when computing expected cond seqno.") which fixes a
> > bug in ovsdb_cs_db_set_condition().  Without it, the returned expected
> > sequence number was wrong, leading to occasional test failures in the
> > OVN test suite.
> >
> > Signed-off-by: Dumitru Ceara <dceara at redhat.com>
> > ---
> > v2: Detailed commit log, as suggested by Mark Michelson.
> > ---
> >  ovs | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ovs b/ovs
> > index ac85cdb38..b5bb044fb 160000
> > --- a/ovs
> > +++ b/ovs
> > @@ -1 +1 @@
> > -Subproject commit ac85cdb38c1f33e7952bc4c0347d6c7873fb56a1
> > +Subproject commit b5bb044fbe4c1395dcde5cc7d5081ef0099bb8b3
> >
>
> Acked-by: Ilya Maximets <i.maximets at ovn.org>

Thanks. I applied the patch to the main branch.

Numan

> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list