[ovs-dev] [PATCH ovn v6] ovn-sbctl.c Add logical flows count numbers

Aaron Conole aconole at redhat.com
Tue Jun 1 12:55:09 UTC 2021


Alexey Roytman <aroytman at gmail.com> writes:

> Hi Aaron, 
>
> These are not operators, but command names. 
> Could you suggest please how to prevent these warnings. ?

There isn't a good way at the moment.  We probably need some additional
logic in checkpatch that can scan the context from the resulting file.

For now, the maintainers know when these warnings are false positives.

Sorry for the noise.

> Thanks Alexey.
>
> On Sat, May 29, 2021 at 8:01 PM 0-day Robot <robot at bytheb.org> wrote:
>
>  Bleep bloop.  Greetings Alexey Roytman, I am a robot and I have tried out your patch.
>  Thanks for your contribution.
>
>  I encountered some error that I wasn't expecting.  See the details below.
>
>  checkpatch:
>  WARNING: Line lacks whitespace around operator
>  #146 FILE: utilities/ovn-sbctl.c:108:
>    lflow-list  [DATAPATH] [LFLOW...] list logical flows for DATAPATH\n\
>
>  WARNING: Line lacks whitespace around operator
>  #147 FILE: utilities/ovn-sbctl.c:109:
>    dump-flows  [DATAPATH] [LFLOW...] alias for lflow-list\n\
>
>  WARNING: Line lacks whitespace around operator
>  #148 FILE: utilities/ovn-sbctl.c:110:
>    count-flows [DATAPATH]            count logical flows for DATAPATH\n\
>
>  Lines checked: 350, Warnings: 3, Errors: 0
>
>  Please check this out.  If you feel there has been an error, please email aconole at redhat.com
>
>  Thanks,
>  0-day Robot



More information about the dev mailing list