[ovs-dev] [PATCH] ovs-save: Fix awk command to return highest ofp version.

Ben Pfaff blp at ovn.org
Thu Jun 3 01:31:01 UTC 2021


On Tue, Jun 01, 2021 at 12:47:19PM +0000, lin huang wrote:
> The quotes for strings like "br0" had been removed.In ovs-save file
> get_highest_ofp_version function still using quotes as field separator.
> That is, get_highest_ofp_version() always return OpenFlow14 version string,
> not the highest ofp version.
> 
> This patch adds support for new string style to return highest ofp version.
> 
> Signed-off-by: linhuang <linhuang at ruijie.com.cn>

Thanks, I applied this to master.  I changed the commit message to:

    ovs-save: Fix awk command to return highest ofp version.
    
    "ovs-vsctl get Bridge "$1" protocols" prints something like this:
      [OpenFlow12, OpenFlow13]
    
    The code in ovs-save didn't parse it properly.  This fixes the
    problem.

because I didn't understand the problem from the previous version.


More information about the dev mailing list