[ovs-dev] [PATCH ovn] ovn-sbctl: Fix lflow-list (etc.) in daemon mode and upon races.

Ben Pfaff blp at ovn.org
Fri Jun 4 00:11:06 UTC 2021


On Thu, Jun 03, 2021 at 07:38:01PM -0400, Numan Siddique wrote:
> On Thu, Jun 3, 2021 at 3:48 PM Ben Pfaff <blp at ovn.org> wrote:
> >
> > Utilities like ovn-sbctl sometimes need to retry their transactions
> > because of races.  For this reason, instead of sending user output
> > directly to stdout, they buffer it until the transaction succeeds.
> > Some of the ovn-sbctl commands didn't do this properly, so they would
> > output multiple times upon a race.  Another way to see the problem
> > was to use daemon mode, in which the output written directly with
> > printf() would not appear at all, since the daemon's stdout is not
> > connected to ovn-sbctl's stdout.
> >
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1965780
> > Reported-by: Alexey Roytman <aroytman at redhat.com>
> 
> Acked-by: Numan Siddique <numans at ovn.org>

Thanks, I applied this to master and branch-21.06.

In theory this could be backported further, because it would also
manifest upon races, but I don't think that's too likely because
ovn-sbctl is rarely used to both modify things and dump flows in a
single transaction.


More information about the dev mailing list