[ovs-dev] [PATCH v3 ovn 0/4] respin CoPP series

Mark Gray mark.d.gray at redhat.com
Fri Jun 4 08:52:22 UTC 2021


On 03/06/2021 23:50, Lorenzo Bianconi wrote:
> This series respin CoPP support introduced here [0] by Dumitru rebasing on top
> of ovn master branch and adding some missing meters (e.g. bfd or acl reject).
> The main goal of this series is to continue the discussion about the proposed
> approach and to align on CMS APIs.
> For the moment no ddlog support has been added.
> Related bz:
> https://bugzilla.redhat.com/show_bug.cgi?id=1947913
> https://bugzilla.redhat.com/show_bug.cgi?id=1946610
> 
> Changes since v2:
> - add sbctl checks in tests/ovn-northd.at unit tests
> - remove letfovers in utilities/ovn-nbctl.8.xml
> 
> Changes since v1:
> - merge patch 3/5 and 4/5
> - cosmetics
> - improve naming conventions
> - add more unit-tests/system-tests
> - remove duplicated flow
> - remove some leftover entries in ovn-nbctl.8.xml
> - add metering for sctp abort packets
> 
> Changes since RFC:
> - drop per-port metering
> - add unit/system tests
> - add reject action metering
> 
> [0] https://patchwork.ozlabs.org/project/openvswitch/list/?series=140778&state=*

Thanks for the changes. They generally look good.

I was unable to compile with ddlog support

./ddlog/bin/ddlog -i northd/ovn_northd.dl -o ./northd -L ./ddlog/lib/lib
-L ./northd

error: northd/ovn_northd.dl:1669.29-1679.5: Missing field
'controller_meter' in constructor OVN_Southbound::Out_Logical_Flow
        sb::Out_Logical_Flow(
                            ^

Also the 0-day robot is complaining. I will do some final testing when
these are fixed.



More information about the dev mailing list