[ovs-dev] [PATCH ovn] if-status: Fix logging of interface creation.

Ilya Maximets i.maximets at ovn.org
Tue Jun 8 17:52:32 UTC 2021


'iface->id' is NULL at this point, so the message is always the same:

   "Interface (null) create."

Fixes: 5c3371922994 ("if-status: Add OVS interface status management module.")
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
---
 controller/if-status.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/controller/if-status.c b/controller/if-status.c
index 8d8c8d436..08fb50b87 100644
--- a/controller/if-status.c
+++ b/controller/if-status.c
@@ -341,7 +341,7 @@ ovs_iface_create(struct if_status_mgr *mgr, const char *iface_id,
 {
     struct ovs_iface *iface = xzalloc(sizeof *iface);
 
-    VLOG_DBG("Interface %s create.", iface->id);
+    VLOG_DBG("Interface %s create.", iface_id);
     iface->id = xstrdup(iface_id);
     shash_add(&mgr->ifaces, iface_id, iface);
     ovs_iface_set_state(mgr, iface, state);
-- 
2.26.3



More information about the dev mailing list