[ovs-dev] [PATCH ovn v2 1/3] lb: Remove hairpin_snat_ips from northd load balancers.

Dumitru Ceara dceara at redhat.com
Thu Jun 10 12:47:35 UTC 2021


The parsed values are not used anywhere so we might as well avoid
parsing them.

Fixes: cc4d5520064f ("Support configuring Load Balancer hairpin source IP.")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
---
 lib/lb.c |    4 ----
 lib/lb.h |    5 -----
 2 files changed, 9 deletions(-)

diff --git a/lib/lb.c b/lib/lb.c
index f305e9a87..992286464 100644
--- a/lib/lb.c
+++ b/lib/lb.c
@@ -242,9 +242,6 @@ ovn_northd_lb_create(const struct nbrec_load_balancer *nbrec_lb,
         ds_chomp(&sel_fields, ',');
         lb->selection_fields = ds_steal_cstr(&sel_fields);
     }
-
-    ovn_lb_get_hairpin_snat_ip(&nbrec_lb->header_.uuid, &nbrec_lb->options,
-                               &lb->hairpin_snat_ips);
     return lb;
 }
 
@@ -281,7 +278,6 @@ ovn_northd_lb_destroy(struct ovn_northd_lb *lb)
     free(lb->vips);
     free(lb->vips_nb);
     free(lb->selection_fields);
-    destroy_lport_addresses(&lb->hairpin_snat_ips);
     free(lb->dps);
     free(lb);
 }
diff --git a/lib/lb.h b/lib/lb.h
index 9a78c72f3..532cf9141 100644
--- a/lib/lb.h
+++ b/lib/lb.h
@@ -38,11 +38,6 @@ struct ovn_northd_lb {
     struct ovn_northd_lb_vip *vips_nb;
     size_t n_vips;
 
-    struct lport_addresses hairpin_snat_ips; /* IP (v4 and/or v6) to be used
-                                              * as source for hairpinned
-                                              * traffic.
-                                              */
-
     size_t n_dps;
     size_t n_allocated_dps;
     const struct sbrec_datapath_binding **dps;



More information about the dev mailing list