[ovs-dev] [PATCH] ofp-monitor: Extend Flow Monitoring support for OF 1.0+ with Nicira Extensions

Ben Pfaff blp at ovn.org
Thu Jun 10 21:32:42 UTC 2021


You can apply a patch like this to get it to log hex:

diff --git a/lib/vconn.c b/lib/vconn.c
index 7415e6291f6f..c626c35f9792 100644
--- a/lib/vconn.c
+++ b/lib/vconn.c
@@ -685,7 +685,7 @@ do_send(struct vconn *vconn, struct ofpbuf *msg)
         COVERAGE_INC(vconn_sent);
         retval = (vconn->vclass->send)(vconn, msg);
     } else {
-        char *s = ofp_to_string(msg->data, msg->size, NULL, NULL, 1);
+        char *s = ofp_to_string(msg->data, msg->size, NULL, NULL, 5);
         retval = (vconn->vclass->send)(vconn, msg);
         if (retval != EAGAIN) {
             VLOG_DBG_RL(&ofmsg_rl, "%s: sent (%s): %s",


On Wed, Jun 09, 2021 at 08:17:18PM -0400, Vasu Dasari wrote:
> Hi Ben,
> 
> I know you might be busy. Can you please share how to construct byte
> stream, I will do it.
> 
> I looked at ovs-ofctl command debug options to see if there is a way to
> print out the byte OpenFlow packet's byte stream, I could not find one.
> 
> Thanks
> -Vasu
> 
> *Vasu Dasari*
> 
> 
> On Fri, May 14, 2021 at 5:09 PM Ben Pfaff <blp at ovn.org> wrote:
> 
> > On Fri, May 14, 2021 at 03:48:53PM -0400, Vasu Dasari wrote:
> > > Hi Ben,
> > >
> > > Quick comment on test case extension. I have added wrappers as you
> > > suggested that code looks good. But I ran into a version specific problem
> > > for testcase, "ofproto - flow monitoring". It uses is a ofctl/send
> > > <
> > https://github.com/openvswitch/ovs/blob/7100c220e669443aa646513ce6cb241ccf2caf5c/tests/ofproto.at#L4695
> > >
> > > command
> > > to perform flow-delete operation, which works well for 1.0 as the byte
> > > stream is handcrafted for version 1. But for any other version, we need
> > to
> > > construct th byte stream and call ofctl/send. So, I left following as it
> > is
> >
> > The easiest way to construct the byte stream is probably to run
> > ovs-ofctl and record what it sends.  It shouldn't be very hard to do
> > that, so I'd just go ahead and do it.
> >


More information about the dev mailing list