[ovs-dev] [PATCH v2] ofp-monitor: Extend Flow Monitoring support for OF 1.0-1.3 with Nicira Extensions

Ben Pfaff blp at ovn.org
Fri Jun 11 00:25:19 UTC 2021

On Fri, May 14, 2021 at 04:15:25PM -0400, Vasu Dasari wrote:
> Currently OVS supports flow-monitoring for OpenFlow 1.0 and Nicira Extenstions.
> Any other OpenFlow versioned messages are not accepted. This checkin will allow
> OpenFlow1.0-1.3 Flow Monitoring wth Nicira extensions be accepted. Also made
> sure that flow-monitoring updates, flow monitoring pause messages, resume
> messages are sent in the same OpenFlow version as that of flow-monitor
> request

Thanks for the patch!

This change here isn't quite accurate since only OF1.0-OF1.3 are
currently supported:

    @@ -515,13 +517,10 @@ parse_flow_monitor_request__(struct ofputil_flow_monitor_request *fmr,

             if (error) {
                 return error;
    -        /* Flow Monitor is supported in OpenFlow 1.0 or can be further reduced
    -         * to a few 1.0 flavors by a match field. */
    -        *usable_protocols &= OFPUTIL_P_OF10_ANY;
         return NULL;

     /* Convert 'str_' (as described in the documentation for the "monitor" command

Actually, it occurs to me that this shouldn't add support for OF1.3
either, only for OF1.1 and OF1.2, because OF1.3 has a standardized
extension, which you can find here:
in the pdf inside for extension 187.  It would be better to implement
that for 1.3 rather than to invent our own.



More information about the dev mailing list