[ovs-dev] [PATCH] ofproto-dpif: fix issue with non-reversible actions on a patch ports
i.maximets at ovn.org
Mon Jun 14 18:15:40 UTC 2021
On 6/14/21 4:28 PM, Eelco Chaudron wrote:
> For patch ports, the is_last_action value is not propagated and is
> always set to true. This causes non-reversible actions to modify the
> packet, and the original content is not preserved when processing
> the remaining actions.
> This patch propagates the is_last_action flag for patch port related
> actions. It also includes a test case
> Signed-off-by: Eelco Chaudron <echaudro at redhat.com>
Hi, Eelco. I didn't review the code, but this change fails a lot
of tests in our CI: https://github.com/ovsrobot/ovs/actions/runs/936204455
Basically it introduces extra clone() actions where was no clones
before and where these clones are not really needed.
Bets regards, Ilya Maximets.
More information about the dev