[ovs-dev] [PATCH 1/2] fail-open: Only fail open if we've been disconnected for at least 1 s.

Ilya Maximets i.maximets at ovn.org
Mon Jun 14 18:59:43 UTC 2021


On 6/11/21 12:49 AM, Ben Pfaff wrote:
> The 'last_disconn_secs' member determines whether we're currently in
> fail-open mode (see fail_open_is_active()), but before this
> commit, fail_open_run() could decide to enter fail-open mode even if
> that would set 'last_disconn_secs' to 0 (and thus not really enter it).
> This could lead to an endless stream of log messages about entering
> fail-open mode, none of which actually does anything.  This fixes the
> problem.
> 
> (This patch worries me because this functionality has been stable
> and unchanged for many years and I wonder how something so simple
> is broken.)

Hmm, I suppose it's just not common to disable inactivity probes on
controller connections.

Acked-by: Ilya Maximets <i.maximets at ovn.org>


More information about the dev mailing list