[ovs-dev] [PATCH v3 ovn 0/5] Handle DNAT/no-NAT conntrack tuple collisions if possible.
numans at ovn.org
Tue Jun 15 20:52:07 UTC 2021
On Fri, Jun 11, 2021 at 6:11 AM Dumitru Ceara <dceara at redhat.com> wrote:
> This depends on the following OVS patch to be accepted:
> However, the capability name, "ct_zero_snat" has been agreed upon so it
> is very unlikely that it will change if new revisions of the OVS patch
> are required.
> - Added Mark Gray's acks to patches 2-4/5.
> - Addressed Mark's comment on the test in patch 5/5:
> - Made the conntrack checks more explicit and added comments
> explaining what output we expect.
> - Also changed the daemonized nc via VIP call to a "nc ... -z" call as
> it's enough to test the functionality and the daemonized call was
> anyway ending immediately after the 3way handshake due to stdin
> being closed when the process was sent to background.
> - Addressed Mark Gray's comments:
> - fix the patch that adds the capability detection mechanism and add
> proper unit tests.
> - improve the system tests.
> - add more details to patch 2/5 commit log.
> - Added Mark's ack to patch 1/5.
> - Added new patch to move GHA CI to nmap-ncat instead of netcat-openbsd.
> Dumitru Ceara (5):
> ovs: Include ovs-vswitchd segfault fixes.
> system-ovn.at: Use ADD_BR macro instead of bare ovs-vsctl.
> github: Use nmap-ncat instead of netcat-openbsd.
> ovn-controller: Detect OVS datapath capabilities.
> ovn-controller: Handle DNAT/no-NAT conntrack tuple collisions.
Thanks for the patches. I applied the first 3 patches of the series
to the main branch and backported
to branch-21.06 as seems like we need the first 3 patches to branch-21.06.
I haven't got the chance to look at the other 2 patches yet.
> .github/workflows/test.yml | 5 +
> controller/ovn-controller.c | 115 +++++++++++++++++++-----
> include/ovn/actions.h | 1
> include/ovn/features.h | 18 ++++
> lib/actions.c | 31 +++++++
> lib/automake.mk | 1
> lib/features.c | 84 ++++++++++++++++++
> lib/test-ovn-features.c | 56 ++++++++++++
> ovs | 2
> tests/automake.mk | 3 +
> tests/ovn-controller.at | 11 +-
> tests/ovn-features.at | 8 ++
> tests/ovn.at | 2
> tests/system-common-macros.at | 4 +
> tests/system-ovn.at | 193 +++++++++++++++++++++++++++++++++++++++++
> tests/testsuite.at | 1
> 16 files changed, 497 insertions(+), 38 deletions(-)
> create mode 100644 lib/features.c
> create mode 100644 lib/test-ovn-features.c
> create mode 100644 tests/ovn-features.at
> dev mailing list
> dev at openvswitch.org
More information about the dev