[ovs-dev] [PATCH] datapath-windows: Specify external include paths
aserdean at ovn.org
Wed Jun 16 15:06:27 UTC 2021
On Tue, 2021-06-15 at 18:06 +0200, Ilya Maximets wrote:
> On 6/15/21 3:43 PM, Alin Gabriel Serdean wrote:
> > VStudio 16.10 adds usermode includes before including the driver
> > kit ones.
> > Bug tracked at:
> > https://developercommunity.visualstudio.com/t/error-lnk2019-unresolved-external-symbol-stdio-com/1434674
> > Fixes appveyor build reported by forcing external includes.
> Thanks, Alin. I know nothing about the windows build process, but I
> that this patch fixes the issue with the current AppVeyor CI,
> Acked-by: Ilya Maximets <i.maximets at ovn.org>
> Out of curiosity, is this change backward compatible? I mean,
> is it possible to build on older platform (older VS) with this
It should be.
Usually we do not need to force the order of include directories. For
kernel projects it should default to the kernel includes.
I test with the last two versions of VS (2019, 2017).
We should add a build matrix for different versions of VS images to
appveyor / GHA so we could be sure.
I'll try to update the appveyor side.
FWIW a new version of VS was launched yesterday (
), I will try to compile
without the patch to see if they hotfixed the issue.
More information about the dev