[ovs-dev] [PATCH ovn] ovn-controller: Propagate nb-cfg-ts to local OVSDB.

Dumitru Ceara dceara at redhat.com
Wed Jun 16 20:40:39 UTC 2021


On 6/16/21 10:25 PM, Dumitru Ceara wrote:
>> Micro-optimization suggestion: Declare a static bool in store_nb_cfg()
>> that indicates when the startup_ts has been written to the OVS DB. Then
>> check it at the beginning of this if statement to avoid the smap lookup
>> of br_int->external_ids when we know it won't be necessary any more.
>>
> Good idea.
> 

O second thought, I'm afraid we have to keep this as is because there's
no guarantee that the ovsdb transaction will succeed.  We have to
reconciliate the database at every run.

Regards,
Dumitru



More information about the dev mailing list