[ovs-dev] [PATCH v4 ovn 3/4] ovn-northd: Add CoPP policies for flows that punt packets to ovn-controller.

Mark Gray mark.d.gray at redhat.com
Fri Jun 18 09:43:46 UTC 2021


On 16/06/2021 11:30, Lorenzo Bianconi wrote:
> -                      "udp.dst == 53",
> -                      REGBIT_DNS_LOOKUP_RESULT" = dns_lookup(); next;");
> +        ovn_lflow_add_ctrl(lflows, od, S_SWITCH_IN_DNS_LOOKUP, 100,
> +                           "udp.dst == 53",

This is a bit of a nit but if you respin the series, it would be good to
change the name of this to "ovn_lflow_metered()" as this seems to be the
convention you used in other functions?

<snip>
>  
>  trigger_event(event = "empty_lb_backends", meter="event-elb" vip = "10.0.0.1:80", protocol = "tcp", load_balancer = "12345678-abcd-9876-fedc-11119f8e7d6c");
> -    formats as trigger_event(event = "empty_lb_backends", meter = "event-elb", vip = "10.0.0.1:80", protocol = "tcp", load_balancer = "12345678-abcd-9876-fedc-11119f8e7d6c");
> -    encodes as controller(userdata=00.00.00.0f.00.00.00.00.00.00.00.00.00.01.00.0b.31.30.2e.30.2e.30.2e.31.3a.38.30.00.02.00.03.74.63.70.00.03.00.24.31.32.33.34.35.36.37.38.2d.61.62.63.64.2d.39.38.37.36.2d.66.65.64.63.2d.31.31.31.31.39.66.38.65.37.64.36.63,meter_id=5)
> +    Syntax error at `meter' expecting empty_lb_backends option name.
>  
Whats happening here? Is this because this test is permanently broke now
because we have changed the way this works?

<snip>



More information about the dev mailing list