[ovs-dev] [PATCH v4 ovn 2/4] ovn-northd: Add support for CoPP.

Lorenzo Bianconi lorenzo.bianconi at redhat.com
Fri Jun 18 11:44:42 UTC 2021


> On 16/06/2021 11:30, Lorenzo Bianconi wrote:
> > +dnl This test is not suported by ovn-northd-ddlog yet.
> > +AT_SKIP_IF([test NORTHD_TYPE = ovn-northd-ddlog && test "$RUN_ANYWAY" != yes])
> 
> One more thing ..
> 
> I am unsure what the policy is with regards to pushing this without
> ddlog support. Perhaps a failure would be better than skipping the test
> because it is more visible and more likely that we will fix it in the
> future?
> 
+ben

I am fine both ways.

@Ben: we were discussing yesterday about the DDLog policy for new features.
In particular, I am fine we need to add DDLog support as well for new ovn-northd features,
but what is the approach when we will be working on other high priority stuff for a while
(this is the case)? Is it ok to merge this series as it is and add DDlog support
in a follow-up seires? This will avoid continue rebasing the code and let
layered products to consume this new feature.
I am 100% fine these are exceptions and in general we need both DDLog anc 'c'
support in the same seires.

Regards,
Lorenzo


More information about the dev mailing list