[ovs-dev] [PATCH ovn v2 5/5] ovn-controller: Fix incremental processing for logical port references.

Dumitru Ceara dceara at redhat.com
Mon Jun 21 09:58:49 UTC 2021


On 6/21/21 8:53 AM, Han Zhou wrote:
> is_cr_cond_present only checks if is_chassis_resident() exists (which would
> reference a logical port). lflow_ref_lookup() checks for all the logical
> port references (not just by is_chassis_resident()).
> For lflows that reference logical ports, we can cache the expr but not the
> match. I wondered if this could impact performance but from my earlier
> tests there was no impact, but maybe there are scenarios that may have
> performance impact but I didn't test.

Makes sense, thanks for the clarification!

> I also noticed that I forgot to remove the variable is_cr_cond_present
> which is not used any more. I removed it in v3.

I'll have a look at v3 this week.

Regards,
Dumitru



More information about the dev mailing list