[ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

Ferriter, Cian cian.ferriter at intel.com
Tue Jun 22 15:08:58 UTC 2021


Hi Flavio,

Thanks for the review. My responses are inline.

Cian

> -----Original Message-----
> From: Flavio Leitner <fbl at sysclose.org>
> Sent: Monday 21 June 2021 19:22
> To: Ferriter, Cian <cian.ferriter at intel.com>
> Cc: ovs-dev at openvswitch.org; i.maximets at ovn.org
> Subject: Re: [ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs
> 
> 
> Hi,
> 
> This commit could be submitted outside of this patch-set as fix
> for commit 9ff7cabfd7 ("dpif-netdev: add subtable-lookup-prio-get
> command") and commit 3d018c3ea79d ("dpif-netdev: add subtable lookup
> prio set command.").
> 
> This helps to get it merged sooner and reduce this patch-set size.
> 

I'll remove this patch from the patchset and send to the mailing list separately.
I'll wait till the DPIF patchset has been merged to send this, since I don't want there to be rebase conflicts (the DPIF patchset also modifies this part of lib/dpif-netdev-unixctl.man).

I'll add the appropriate Fixes tags.

> Thanks for documenting it.
> fbl
> 
> On Thu, Jun 17, 2021 at 05:18:21PM +0100, Cian Ferriter wrote:
> > Signed-off-by: Cian Ferriter <cian.ferriter at intel.com>
> >
> > ---
> >
> > v13:
> > - New commit to update manpages with more commands that are missing.
> > ---
> >  lib/dpif-netdev-unixctl.man | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/lib/dpif-netdev-unixctl.man b/lib/dpif-netdev-unixctl.man
> > index 45a1bd669..d77f5d9a4 100644
> > --- a/lib/dpif-netdev-unixctl.man
> > +++ b/lib/dpif-netdev-unixctl.man
> > @@ -228,6 +228,16 @@ When this is the case, the above command prints the load-balancing
> information
> >  of the bonds configured in datapath \fIdp\fR showing the interface associated
> >  with each bucket (hash).
> >  .
> > +.IP "\fBdpif-netdev/subtable-lookup-prio-get\fR"
> > +Lists the DPCLS implementations or lookup functions that are available as well
> > +as their priorities.
> > +.
> > +.IP "\fBdpif-netdev/subtable-lookup-prio-set\fR \fIlookup_function\fR \
> > +\fIprio\fR"
> > +Sets the priority of a lookup function by the name, \fIlookup_function\fR, and
> > +the priority, \fIprio\fR, which should be a positive integer value. The highest
> > +priority lookup function is used for classification.
> > +.
> >  .IP "\fBdpif-netdev/dpif-get\fR
> >  Lists the DPIF implementations that are available.
> >  .
> > --
> > 2.32.0
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> 
> --
> fbl


More information about the dev mailing list