[ovs-dev] [PATCH v3] [python] Don't mix system poll/monkeypatched select

Ben Pfaff blp at ovn.org
Tue Jun 22 16:51:39 UTC 2021


On Tue, Jun 15, 2021 at 10:06:53PM +0200, Ilya Maximets wrote:
> 3. Use select() + getsockopt(SO_ERRROR), effectively revert d6cedfd9d29d
>    --> give up on systems that doesn't support SO_ERRROR. (ESX?)

d6cedfd9d29d is the commit titled "socket-util: Avoid using SO_ERROR."
from 2012.  This was right after the Nicira acquisition when we were
trying to port OVS to ESX.  We dropped that effort later and took a
different strategy on ESX.  You can kind of see that since there are no
references to ESX in the log from 2014 to 2019 and the one in 2019 is
commit e6fc4e2ce97e ("Remove ESX references.").

So, in short, ESX doesn't matter, go ahead and use SO_ERROR.


More information about the dev mailing list