[ovs-dev] [PATCH ovn] northd: avoid memory reallocation while building ACL and QoS rules

Dan Williams dcbw at redhat.com
Tue Jun 22 17:14:46 UTC 2021


On Fri, 2021-06-18 at 21:49 +0200, Dumitru Ceara wrote:
> On 6/4/21 10:00 PM, Dan Williams wrote:
> > Inspried by:
> > 
> > 3b6362d64e86b northd: Avoid memory reallocation while building lb
> > rules.
> > 
> > Signed-off-by: Dan Williams <dcbw at redhat.com>
> > ---
> > NOTE: this is driven by visual inspection not perf data. But it
> > shouldn't be worse than current code and should be better for
> > large numbers of ACLs I think.
> 
> The changes look OK to me.
> 
> Acked-by: Dumitru Ceara <dceara at redhat.com>
> 
> However, I wonder how many such optimizations we can implement
> without
> affecting maintainability.  Mark suggested an approach [0].

I'm happy to drop my patch in favor of Mark's. I think mine is a subset
of his.

Dan

> 
> CC-ing Ilya too, maybe he has some more suggestions, maybe there's a
> way
> to better use the OVS dynamic strings.
> 
> Regards,
> Dumitru
> 
> [0]
> https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/384043.html
> 




More information about the dev mailing list