[ovs-dev] [PATCH v2] dpif-netdev: apply subtable-lookup-prio-set on any datapath

Van Haaren, Harry harry.van.haaren at intel.com
Thu Jun 24 09:18:53 UTC 2021


> -----Original Message-----
> From: Timothy Redaelli <tredaelli at redhat.com>
> Sent: Wednesday, June 23, 2021 11:10 PM
> To: dev at openvswitch.org
> Cc: Van Haaren, Harry <harry.van.haaren at intel.com>
> Subject: [PATCH v2] dpif-netdev: apply subtable-lookup-prio-set on any datapath
> 
> Currently, if you try to set subtable-lookup-prio-set when you don't have
> any datapath (for example if an user wants to set AVX512 before creating
> any bridge) it sets it globally (dpcls_subtable_set_prio),
> but it returns an error:
> 
>   please specify an existing datapath
>   ovs-appctl: ovs-vswitchd: server returned an error
> 
> and, in this case, the exit code of ovs-appctl is 2.

Good catch. Just to call out that the command was actually having effect,
just that because there was no datapath to update, it was later "failing" to
find a datapath hence error return.


> This commit changes the behaviour by removing the [datapath] optional
> parameter of subtable-lookup-prio-set and by changing the priority
> level on any datapath and globally. This means if you don't have any
> datapath or if you have only one datapath, the behaviour is the same as
> now, but without the confusing error when you don't have any datapath.
> 
> Fixes: 3d018c3ea79d ("dpif-netdev: add subtable lookup prio set command.")
> Cc: harry.van.haaren at intel.com
> Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>

I like the code simplification, and command UX simplification too, thanks!

Acked-by: Harry van Haaren <harry.van.haaren at intel.com>



More information about the dev mailing list