[ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

Dumitru Ceara dceara at redhat.com
Thu Jun 24 17:33:14 UTC 2021


On 6/24/21 7:20 PM, Han Zhou wrote:
> For the reason mentioned above, we can't make this change. In fact, I
> wouldn't worry much about lflow_ref_lookup()'s cost. It is O(1) operation.
> If it really turns out to be a bottleneck, we could optimize the
> function/data-structure, without worrying about the logic.
> The real performance impact part is probably not being able to cache the
> "match" for lflows that have logical port references, but I will work on
> some other solutions to optimize that.

OTOH, on real deployments the lflow cache limits should be enforced by
the CMS.  Therefore I would expect some of these flows to not make it in
the cache anyway (even without your change).  I don't have data to back
this up but I'm guessing the impact of the change in this patch will be
minimal.

Regards,
Dumitru



More information about the dev mailing list