[ovs-dev] [PATCH ovn v4] ovn.at: Fix test "virtual ports -- ovn-northd-ddlog".

Han Zhou hzhou at ovn.org
Thu Jun 24 21:56:58 UTC 2021


On Thu, Jun 24, 2021 at 12:15 PM Ben Pfaff <blp at ovn.org> wrote:
>
> On Mon, Jun 21, 2021 at 06:55:29PM -0700, Han Zhou wrote:
> > The test case fails quite often for northd-ddlog because of the tunnel
> > keys mismatch when comparing OpenFlow rules. Keys can change in
> > different runs. This patch fixes it by extracting the expected keys from
> > SB DB before comparison instead of hardcoding.
> >
> > There are some other potential timing issues in this test and this
> > patch fixes them as well by replacing AT_CHECK with wait_column.
> >
> > Signed-off-by: Han Zhou <hzhou at ovn.org>
>
> I didn't test this but it looks right.
>
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks Ben. I applied it to the master branch and branch-21.06. (I merged
to 21.06 not because it is a critical bug fix (it is not), but because
frequent test case failures could hide real bugs for future changes)


More information about the dev mailing list