[ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search info logs

Stokes, Ian ian.stokes at intel.com
Tue Jun 29 16:40:19 UTC 2021


> From: Harry van Haaren <harry.van.haaren at intel.com>
> 
> This commit avoids many instances of "using subtable X for miniflow (x,y)"
> in the ovs-vswitchd log when using the DPCLS Autovalidator. This occurs
> when no specialized subtable is found, and the generic "_any" version of
> the avx512 subtable search implementation was used. This change logs the
> subtable usage once, avoiding duplicates.
> 

Good point here, I think people forget there is a cost to logs and no need to flood them.

Just to confirm, I think this log is already upstream? What I mean is that it is not added by either the DPIF or MFEX patch series so this is the earliest we can make the change on it?

Regards
Ian
> Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
> ---
>  lib/dpif-netdev-lookup-avx512-gather.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dpif-netdev-lookup-avx512-gather.c b/lib/dpif-netdev-lookup-
> avx512-gather.c
> index 2e754c89f..deed527b0 100644
> --- a/lib/dpif-netdev-lookup-avx512-gather.c
> +++ b/lib/dpif-netdev-lookup-avx512-gather.c
> @@ -411,7 +411,7 @@ dpcls_subtable_avx512_gather_probe(uint32_t u0_bits,
> uint32_t u1_bits)
>       */
>      if (!f && (u0_bits + u1_bits) < (NUM_U64_IN_ZMM_REG * 2)) {
>          f = dpcls_avx512_gather_mf_any;
> -        VLOG_INFO("Using avx512_gather_mf_any for subtable (%d,%d)\n",
> +        VLOG_INFO_ONCE("Using avx512_gather_mf_any for subtable
> (%d,%d)\n",
>                    u0_bits, u1_bits);
>      }
> 
> --
> 2.25.1
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list