[ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search info logs
Van Haaren, Harry
harry.van.haaren at intel.com
Tue Jun 29 16:46:27 UTC 2021
> -----Original Message-----
> From: Stokes, Ian <ian.stokes at intel.com>
> Sent: Tuesday, June 29, 2021 5:40 PM
> To: Amber, Kumar <kumar.amber at intel.com>; dev at openvswitch.org
> Cc: i.maximets at ovn.org; Ferriter, Cian <cian.ferriter at intel.com>; Van Haaren,
> Harry <harry.van.haaren at intel.com>
> Subject: RE: [ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search info logs
> > From: Harry van Haaren <harry.van.haaren at intel.com>
> > This commit avoids many instances of "using subtable X for miniflow (x,y)"
> > in the ovs-vswitchd log when using the DPCLS Autovalidator. This occurs
> > when no specialized subtable is found, and the generic "_any" version of
> > the avx512 subtable search implementation was used. This change logs the
> > subtable usage once, avoiding duplicates.
> Good point here, I think people forget there is a cost to logs and no need to flood
> Just to confirm, I think this log is already upstream? What I mean is that it is not
> added by either the DPIF or MFEX patch series so this is the earliest we can make the
> change on it?
This change can be made earlier. The logs spam gets worse if we use the autovalidator, so it was
identified as an issue to fix when testing with MFEX autovalidator && DPCLS autovalidator,
hence why here in the patchset.
Can submit separately if preferred.
Thanks for review, -Harry
<snip patch contents>
More information about the dev