[ovs-dev] [PATCH ovn] ovs-sandbox: Allow specifying initial contents for NB and SB database.

0-day Robot robot at bytheb.org
Tue Jun 29 19:05:02 UTC 2021


Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line has non-spaces leading whitespace
#73 FILE: tutorial/ovs-sandbox:284:
	--nbdb-so*=*)

WARNING: Line has non-spaces leading whitespace
#74 FILE: tutorial/ovs-sandbox:285:
	    ovnnb_source=$optarg

WARNING: Line has non-spaces leading whitespace
#75 FILE: tutorial/ovs-sandbox:286:
	    ;;

WARNING: Line has non-spaces leading whitespace
#76 FILE: tutorial/ovs-sandbox:287:
	--nbdb-so*)

WARNING: Line has non-spaces leading whitespace
#77 FILE: tutorial/ovs-sandbox:288:
	    prev=ovnnb_source

WARNING: Line has non-spaces leading whitespace
#78 FILE: tutorial/ovs-sandbox:289:
	    ;;

WARNING: Line has non-spaces leading whitespace
#92 FILE: tutorial/ovs-sandbox:304:
	--sbdb-so*=*)

WARNING: Line has non-spaces leading whitespace
#93 FILE: tutorial/ovs-sandbox:305:
	    ovnsb_source=$optarg

WARNING: Line has non-spaces leading whitespace
#94 FILE: tutorial/ovs-sandbox:306:
	    ;;

WARNING: Line has non-spaces leading whitespace
#95 FILE: tutorial/ovs-sandbox:307:
	--sbdb-so*)

WARNING: Line has non-spaces leading whitespace
#96 FILE: tutorial/ovs-sandbox:308:
	    prev=ovnsb_source

WARNING: Line has non-spaces leading whitespace
#97 FILE: tutorial/ovs-sandbox:309:
	    ;;

WARNING: Line has non-spaces leading whitespace
#109 FILE: tutorial/ovs-sandbox:397:
	: ${ovnnb_source:=$srcdir/ovn-nb.ovsschema}

WARNING: Line has non-spaces leading whitespace
#110 FILE: tutorial/ovs-sandbox:398:
	if test ! -e "$ovnnb_source"; then

WARNING: Line is 111 characters long (recommended limit is 79)
WARNING: Line has non-spaces leading whitespace
#111 FILE: tutorial/ovs-sandbox:399:
	    echo >&2 "OVN northbound database source $ovnnb_source not found, please check --srcdir or --ovnnb-source"

WARNING: Line has non-spaces leading whitespace
#112 FILE: tutorial/ovs-sandbox:400:
	    exit 1

WARNING: Line has non-spaces leading whitespace
#118 FILE: tutorial/ovs-sandbox:402:
	: ${ovnsb_source:=$srcdir/ovn-sb.ovsschema}

WARNING: Line has non-spaces leading whitespace
#119 FILE: tutorial/ovs-sandbox:403:
	if test ! -e "$ovnsb_source"; then

WARNING: Line is 111 characters long (recommended limit is 79)
WARNING: Line has non-spaces leading whitespace
#120 FILE: tutorial/ovs-sandbox:404:
	    echo >&2 "OVN southbound database source $ovnsb_source not found, please check --srcdir or --ovnsb-source"

WARNING: Line has non-spaces leading whitespace
#121 FILE: tutorial/ovs-sandbox:405:
	    exit 1

WARNING: Line has non-spaces leading whitespace
#136 FILE: tutorial/ovs-sandbox:506:
	source_type=schema

WARNING: Line has non-spaces leading whitespace
#138 FILE: tutorial/ovs-sandbox:508:
	source_type=database

WARNING: Line has non-spaces leading whitespace
#140 FILE: tutorial/ovs-sandbox:510:
	echo "$source is not an OVSDB schema or database" >&2

WARNING: Line has non-spaces leading whitespace
#141 FILE: tutorial/ovs-sandbox:511:
	exit 1

WARNING: Line has non-spaces leading whitespace
#151 FILE: tutorial/ovs-sandbox:546:
	    case $source_type in

WARNING: Line has non-spaces leading whitespace
#152 FILE: tutorial/ovs-sandbox:547:
		database) run cp "$source" ${db}1.db ;;

WARNING: Line has non-spaces leading whitespace
#153 FILE: tutorial/ovs-sandbox:548:
		schema) run ovsdb-tool create ${db}1.db "$source" ;;

WARNING: Line has non-spaces leading whitespace
#154 FILE: tutorial/ovs-sandbox:549:
	    esac

WARNING: Line has non-spaces leading whitespace
#161 FILE: tutorial/ovs-sandbox:555:
		case $source_type in

WARNING: Line has non-spaces leading whitespace
#162 FILE: tutorial/ovs-sandbox:556:
		    database) run cp "$source" $db$i.db ;;

WARNING: Line has non-spaces leading whitespace
#163 FILE: tutorial/ovs-sandbox:557:
		    schema) run ovsdb-tool create $db$i.db "$source" ;;

WARNING: Line has non-spaces leading whitespace
#164 FILE: tutorial/ovs-sandbox:558:
		esac

WARNING: Line is 87 characters long (recommended limit is 79)
#173 FILE: tutorial/ovs-sandbox:573:
                    run ovsdb-tool create-cluster ${db}1.db "$source" unix:${db}1.raft;

Lines checked: 190, Warnings: 35, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list