[ovs-dev] [v13 06/12] dpif-netdev: Add command to get dpif implementations.

Ferriter, Cian cian.ferriter at intel.com
Wed Jun 30 09:35:29 UTC 2021


Hi Eelco,

Thanks for you comment. My reply is inline.

Cian

> -----Original Message-----
> From: Eelco Chaudron <echaudro at redhat.com>
> Sent: Tuesday 29 June 2021 09:25
> To: Ferriter, Cian <cian.ferriter at intel.com>; Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: ovs-dev at openvswitch.org; i.maximets at ovn.org; Flavio Leitner <fbl at sysclose.org>
> Subject: Re: [ovs-dev] [v13 06/12] dpif-netdev: Add command to get dpif implementations.
> 
> 
> 
> On 17 Jun 2021, at 18:18, Cian Ferriter wrote:
> 
> > From: Harry van Haaren <harry.van.haaren at intel.com>
> >
> > This commit adds a new command to retrieve the list of available
> > DPIF implementations. This can be used by to check what implementations
> > of the DPIF are available in any given OVS binary.
> >
> > Usage:
> >  $ ovs-appctl dpif-netdev/dpif-get
> >
> 
> This command only shows the actual available options, not the currently selected ones.
> 
> I think from a support perspective, we need this command to also show the current setting for each
> datapath. Having this only in the log will not work in cases where the log is overwritten.

Yes, good idea. More visibility here is a good suggestion, rather than fishing through the logs to see what DPIF is set.

> 
> //Eelco
> 
> Guess this also is true for the MFEX patchset (will reply during my review) and the already included
> “ovs-appctl dpif-netdev/subtable-lookup-prio-get”
> 
> <SNIP>


I'll improve the DPIF get command as per your suggestion. I'm following the thread where the DPIF, MFEX and DPCLS get commands are being discussed. I'll take the output of this thread into account for the next revision of the dpif-impl-get command.

Thread:
https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/384644.html


More information about the dev mailing list