[ovs-dev] [PATCH ovn v3 2/3] ovn-northd: Add useful stopwatches
dceara at redhat.com
Wed Jun 30 13:50:09 UTC 2021
On 6/30/21 2:49 PM, Mark Gray wrote:
> On 24/06/2021 16:33, Dumitru Ceara wrote:
>> On 6/18/21 10:52 AM, Mark Gray wrote:
>>> For performance measurement, it is useful to understand the
>>> length of time required to complete a number of key code paths
>>> in ovn-northd.c. Add stopwatches to measure these timings.
>>> Signed-off-by: Mark Gray <mark.d.gray at redhat.com>
>> Acked-by: Dumitru Ceara <dceara at redhat.com>
>> I only have one real nit on this patch (below). Except for that here
>> are some more random thoughts for potential follow ups.
>> I think we might benefit from a even more granular measurement, e.g., in
>> some of the tests I was doing a while ago build_datapaths() was also
>> taking up a significant amount of time.
> Yes, I think so too. However, I don't want to start cluttering the code
> with stopwatches put in arbitrary locations. I would rather it was
> driven by actual need. I don't feel particularly qualified to make that
> decision and I figured this patch is more about establishing the precedent.
You're right, let's take it one step at a time.
>> Some more interesting ones to measure are in
>> build_lswitch_and_lrouter_flows(), the loops that call
>> build_lswitch_*_by_od/op(). I don't know however how we could deal with
>> the parallel case though.
> I could add these as an additional patch if you are convinced of their
Same as above, I'd say let's take it one step at a time, unless someone
else has a easy-to-implement idea.
More information about the dev