[ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search info logs

Amber, Kumar kumar.amber at intel.com
Wed Jun 30 15:11:07 UTC 2021


Thanks Eelco sure go ahead :) upgrade will surely raise the pps! 

> -----Original Message-----
> From: Eelco Chaudron <echaudro at redhat.com>
> Sent: Wednesday, June 30, 2021 8:27 PM
> To: Amber, Kumar <kumar.amber at intel.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>
> Cc: dev at openvswitch.org; i.maximets at ovn.org; Stokes, Ian
> <ian.stokes at intel.com>; Flavio Leitner <fbl at sysclose.org>
> Subject: Re: [ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search info logs
> 
> No additional comments on this patch! This concludes my review of v4, looking
> forward to v5.
> 
> I will now do some additional tests on my non AVX512 machine. Guess I need to
> update my Intel NUC to an AVX512 supported one :)
> 
> //Eelco
> 
> 
> On 17 Jun 2021, at 18:27, Kumar Amber wrote:
> 
> > From: Harry van Haaren <harry.van.haaren at intel.com>
> >
> > This commit avoids many instances of "using subtable X for miniflow (x,y)"
> > in the ovs-vswitchd log when using the DPCLS Autovalidator. This
> > occurs when no specialized subtable is found, and the generic "_any"
> > version of the avx512 subtable search implementation was used. This
> > change logs the subtable usage once, avoiding duplicates.
> >
> > Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
> > ---
> >  lib/dpif-netdev-lookup-avx512-gather.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/dpif-netdev-lookup-avx512-gather.c
> > b/lib/dpif-netdev-lookup-avx512-gather.c
> > index 2e754c89f..deed527b0 100644
> > --- a/lib/dpif-netdev-lookup-avx512-gather.c
> > +++ b/lib/dpif-netdev-lookup-avx512-gather.c
> > @@ -411,7 +411,7 @@ dpcls_subtable_avx512_gather_probe(uint32_t
> u0_bits, uint32_t u1_bits)
> >       */
> >      if (!f && (u0_bits + u1_bits) < (NUM_U64_IN_ZMM_REG * 2)) {
> >          f = dpcls_avx512_gather_mf_any;
> > -        VLOG_INFO("Using avx512_gather_mf_any for subtable (%d,%d)\n",
> > +        VLOG_INFO_ONCE("Using avx512_gather_mf_any for subtable
> > + (%d,%d)\n",
> >                    u0_bits, u1_bits);
> >      }
> >
> > --
> > 2.25.1
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev



More information about the dev mailing list