[ovs-dev] [PATCH 0/1] flow dumps containing igmp match cannot be restored

Adrian Moreno amorenoz at redhat.com
Wed Jun 30 15:43:53 UTC 2021

As discussed in [1], "igmp" is not a special OF header so
ofp_parse_protocol() does not accept it. However, it's still being
printed by match_format().

This makes flow dump restoration fail if it contains this match,
which affects for instance the ovs-save script used by "ovs-ctl restart"
to make ovs-vswitchd restart have less impact on the datapath.

I am aware this change might break users that already expect this
keyword but on the other hand, the fact that flows cannot be saved and
restored could be considered a bug.

An alternative to make "ovs-save" work would be to use "sed" to rewrite
the match, but that would still expose the failure to any user not using
that script.

Sending the patch to gather feedback on this topic

[1] https://patchwork.ozlabs.org/project/openvswitch/patch/20201102232805.1960103-1-blp@ovn.org/

Adrian Moreno (1):
  match: do not print "igmp" match keyword

 lib/match.c        | 2 --
 tests/ovs-ofctl.at | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)


More information about the dev mailing list