[ovs-dev] [PATCH v2 0/2] ovsdb-idl: Preserve references for tracked deleted rows.
numans at ovn.org
Fri Mar 5 09:15:37 UTC 2021
On Wed, Mar 3, 2021 at 8:09 PM Dumitru Ceara <dceara at redhat.com> wrote:
> The first patch of the series makes the ovsdb-idl tests more future
> proof by trying to ensure more predictable output from test-ovsdb.
> The second patch of the series fixes a problem with the IDL change
> tracking code for deleted records which was causing OVN to crash due to
> strong reference fields in IDL records not being preserved at row
> Changes in v2:
> - Patch 1/2:
> - reworked the patch to improve the output of test-ovsdb.c and
> test-ovsdb.py themselves.
> - Patch 2/2:
> - added a test for strong references.
> Dumitru Ceara (2):
> ovsdb-idl.at: Make test outputs more predictable.
> ovsdb-idl: Preserve references for deleted rows.
I'm not completely familiar with the tracking IDL code. The patch
series looks good to me.
For the whole series
Acked-by: Numan Siddique <numans at ovn.org>
Tested this patch locally. This patch series is applied on our
internal openstack + ovn deployment
since a couple of days (where the issue is seen). And we have not seen
any crashes since then.
Tested-by: Numan Siddique <numans at ovn.org>
> lib/ovsdb-idl.c | 9 -
> lib/ovsdb-idl.h | 2
> tests/ovsdb-idl.at | 581 ++++++++++++++++++++++++++++++---------------------
> tests/test-ovsdb.c | 231 ++++++++++++++------
> tests/test-ovsdb.py | 87 ++++----
> 5 files changed, 556 insertions(+), 354 deletions(-)
> dev mailing list
> dev at openvswitch.org
More information about the dev