[ovs-dev] [PATCH ovn] ovn-northd-ddlog: Fix error checking in ddlog_commit().

Ben Pfaff blp at ovn.org
Wed Mar 10 00:44:46 UTC 2021


new_delta has the error status but this function was checking a
different variable instead.

Found by inspection.;

Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 northd/ovn-northd-ddlog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/northd/ovn-northd-ddlog.c b/northd/ovn-northd-ddlog.c
index 238987410239..81ea8c144a96 100644
--- a/northd/ovn-northd-ddlog.c
+++ b/northd/ovn-northd-ddlog.c
@@ -320,7 +320,7 @@ static int
 ddlog_commit(ddlog_prog ddlog)
 {
     ddlog_delta *new_delta = ddlog_transaction_commit_dump_changes(ddlog);
-    if (!delta) {
+    if (!new_delta) {
         VLOG_WARN("Transaction commit failed");
         return -1;
     }
-- 
2.29.2



More information about the dev mailing list