[ovs-dev] [PATCH ovn] ovs: Bump submodule version to latest ovsdb-cs changes.
i.maximets at ovn.org
Thu Mar 11 20:40:18 UTC 2021
On 3/11/21 8:31 PM, Ben Pfaff wrote:
> On Thu, Mar 11, 2021 at 08:08:18PM +0100, Ilya Maximets wrote:
>> On 3/11/21 7:53 PM, Ben Pfaff wrote:
>>> On Thu, Mar 11, 2021 at 07:37:19PM +0100, Ilya Maximets wrote:
>>>> Few bugfixes was accepted recently to OVS for ovsdb-cs code
>>>> that are required for OVN build.
>>>> e.g. ac09cbfcb70a ("ovsdb-cs: Fix use-after-free for the request id.")
>>>> This will also include all the changes necessary to build
>>>> ddlog version of northd.
>>>> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
>>>> ovs | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>> diff --git a/ovs b/ovs
>>>> index 50e5523b9..ac09cbfcb 160000
>>>> --- a/ovs
>>>> +++ b/ovs
>>>> @@ -1 +1 @@
>>>> -Subproject commit 50e5523b9b2b154e5fafc5acdcdec85e9cc5a330
>>>> +Subproject commit ac09cbfcb70ac6f443f039d5934448bd80f74493
>>> You could consider bumping all the way to 39b937f06434 ("raft: Add
>>> 'stop-raft-rpc' failure test command."), which would add the commits
>>> listed below.
>> OVN itself doesn't use the raft code, so it doesn't really matter
>> if these commits included or not. I don't see a big difference
>> between bumping to 39b937f06434 and just to current tip of the
>> master branch. I think it's probably better to just stick to
>> necessary changes.
>> OTOH, someone might try to actually build and use OVS from this
>> submodule... We probably need to discourage users from doing that
> I actually thought that the submodule was a recommended OVS version as
> well as what OVN builds against. If that's not so, then yes we should
> clarify somehow.
It's a recommended OVS version to build with. I'd not recommend using
it to actually build ovs-vswitchd or ovsdb-server, because it will
mean that you're running non-released version of OVS that is always
behind even the master branch.
Looking at the OVN documentation from this perspective I see that it
very loose in operation with word "use". I think it should mean "build with",
but it's definitely not obvious.
I've sent a patch to clarify the documentation:
Best regards, Ilya Maximets.
More information about the dev