[ovs-dev] [PATCH ovn v2] ci: Fix handling of python packages.

Numan Siddique numans at ovn.org
Mon Mar 15 11:36:11 UTC 2021


On Mon, Mar 15, 2021 at 3:48 PM Dumitru Ceara <dceara at redhat.com> wrote:
>
> On 3/12/21 7:25 PM, Ilya Maximets wrote:
> > GitHub Actions doesn't have python locations in PATH and different
> > runners might have different configuration for default python
> > location and versions.  For example, on some runners python2 might
> > be installed or not.
> >
> > Missing PATH causes weird situations where during one run our scripts
> > can locate just installed flake8 and can't do that on a different run.
> >
> > Also, we're mistakenly installing python2 version of flake8.
> > On runners that able to locate installed flake8 this causes breakage
> > of a flake8-check build target because our python scripts written for
> > python3.  And runners that can't locate flake8 works just fine and
> > job succeeds.
> >
> > It's required to use actions/setup-python at v2 in order to have
> > predictable version of python installed and paths correctly configured.
> > Due to some bugs in GHA itself it doesn't set $HOME/.local/bin into
> > PATH, so we have to do that manually for now in order to use '--user'.
> >
> > Unfortunately actions/setup-python at v2 also makes invisible python
> > packages installed from Ubuntu repositories.  Switching them to
> > 'pip3 install'.
> >
> > 'six' package is not needed, so it's dropped.
> >
> > Fixes: ecdd790ecbff ("CI: Add github actions workflow.")
> > Reported-by: Numan Siddique <numans at ovn.org>
> > Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> > ---
>
> Looks good to me, thanks!
>
> Acked-by: Dumitru Ceara <dceara at redhat.com>

Thanks Ilya for fixing this CI issue and Dumitru for the reviews.

I applied this patch to the main branch and back ported upto branch-20.03.

Numan


>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list