[ovs-dev] [PATCH V4 05/14] netdev-offload-dpdk: Implement HW miss packet recover for vport

Ivan Malov Ivan.Malov at oktetlabs.ru
Wed Mar 17 08:48:43 UTC 2021


Hi Eli,

On 17/03/2021 09:35, Eli Britstein wrote:
> +        parse_tcp_flags(packet);
> +        if (vport_netdev->netdev_class->pop_header(packet) == NULL) {

Thank you for revising the patch series. As far as I can see, in the new 
revision (patch [06/14]), parsing TCP flags is done after successful 
miss recovery (which yields a decapsulated packet), and that should be 
fairly correct. However, why also call parse_tcp_flags() over here, 
before popping the header? This invocation doesn't make use of the 
returned value...

(Sorry if I simply misread the code).

-- 
Ivan M


More information about the dev mailing list