[ovs-dev] [PATCH ovn v4] ovn-controller: Split logical flow and phsyical flow processing.

Han Zhou hzhou at ovn.org
Thu Mar 18 07:05:26 UTC 2021


On Thu, Mar 11, 2021 at 11:08 AM Numan Siddique <numans at ovn.org> wrote:
> > > +struct ovn_flow_table {
> > > +    struct ovn_desired_flow_table desired_ftable;
> > > +    struct hmap installed_flows;
> >
> > It seems to me "installed_flows" shouldn't belong to the engine data.
Would
> > it be better to keep installed_flows static in ofctrl module?
>
> I thought about this.  If we keep it as static, then we need to have
> hmap installed_pflows  and hmap installed_lflows.

Yes, we can keep them as separate static variables.

>
> How would we figure out which hmap to update when lflow.c calls
> ofctrl_add_flow() ?
>
> Or do you mean just have a single hmap - installed_flows ?
>

Sorry that I don't see any problem of calling ofctrl_add_flow().
ofctrl_add_flow() only needs to know the desired flow table, not the
installed_flows table, right?


More information about the dev mailing list