[ovs-dev] [PATCH v3] dpif-netdev: Allow PMD auto load balance with cross-numa.

Ilya Maximets i.maximets at ovn.org
Mon Mar 22 12:01:16 UTC 2021


On 3/18/21 12:34 PM, Kevin Traynor wrote:
> Previously auto load balance did not trigger a reassignment when
> there was any cross-numa polling as an rxq could be polled from a
> different numa after reassign and it could impact estimates.
> 
> In the case where there is only one numa with pmds available, the
> same numa will always poll before and after reassignment, so estimates
> are valid. Allow PMD auto load balance to trigger a reassignment in
> this case.
> 
> Acked-by: Eelco Chaudron <echaudro at redhat.com>
> Acked-by: David Marchand <david.marchand at redhat.com>
> Tested-by: Sunil Pai G <sunil.pai.g at intel.com>
> Acked-by: Flavio Leitner <fbl at sysclose.org>
> Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
> ---
> https://github.com/kevintraynor/ovs/actions/runs/664214192
> v3:
> - Updated docs and logs as per Ilya suggestion
> v2:
> - Same logic as v1, combined two "ifs" as per David suggestion
> - Updated comments/logs
> - Updated the doc note that said it will not work for cross NUMA to
>   include new condition
> - Kept Eelco's Ack, as no logic changed
> ---
>  Documentation/topics/dpdk/pmd.rst |  4 +++-
>  lib/dpif-netdev.c                 | 19 ++++++++++++++++---
>  2 files changed, 19 insertions(+), 4 deletions(-)

Thanks!  I added a NEWS entry and applied to master.

Best regards, Ilya Maximets.


More information about the dev mailing list