[ovs-dev] [PATCH ovn] ovn-nbctl: update BFD rows in nbctl_lr_route_del routine

Ilya Maximets i.maximets at ovn.org
Wed Mar 24 12:40:12 UTC 2021


On 3/24/21 12:26 PM, Numan Siddique wrote:
> On Tue, Mar 23, 2021 at 12:11 AM Mark Michelson <mmichels at redhat.com> wrote:
>>
>> Correct me if I'm wrong, but couldn't this be done automatically by just
>> setting "isRoot: false" for the BFD table in ovn-nb.ovsschema?
> 
> I think changing to isRoot: false could have upgrade issues.
> 
> IMO, since CMS creates the BFD rows, it's better for it to delete when
> it's not required.  Although I'm not against this patch.
> 

One more comment here:  Enforcing this policy (remove entry if there are no
users) on the ovn-nbctl level will result in different behavior for different
users.  e.g. if someone will perform the same action (remove static route)
directly via jsonrpc or some library like go-ovn, they will not have the BFD
row deleted.  This might complicate things like migration from nbctl to go-ovn
in ovn-k8s.  And since this behavior is not specified in a DB schema, this
should be, at least, clearly documented.

Bets regards, Ilya Maximets.


More information about the dev mailing list