[ovs-dev] [PATCH ovn] ovn-nbctl: update BFD rows in nbctl_lr_route_del routine

Lorenzo Bianconi lorenzo.bianconi at redhat.com
Wed Mar 24 13:18:47 UTC 2021

> On 3/24/21 12:26 PM, Numan Siddique wrote:
> > On Tue, Mar 23, 2021 at 12:11 AM Mark Michelson <mmichels at redhat.com> wrote:
> >>
> >> Correct me if I'm wrong, but couldn't this be done automatically by just
> >> setting "isRoot: false" for the BFD table in ovn-nb.ovsschema?
> > 
> > I think changing to isRoot: false could have upgrade issues.
> > 
> > IMO, since CMS creates the BFD rows, it's better for it to delete when
> > it's not required.  Although I'm not against this patch.
> > 
> One more comment here:  Enforcing this policy (remove entry if there are no
> users) on the ovn-nbctl level will result in different behavior for different
> users.  e.g. if someone will perform the same action (remove static route)
> directly via jsonrpc or some library like go-ovn, they will not have the BFD
> row deleted.  This might complicate things like migration from nbctl to go-ovn
> in ovn-k8s.  And since this behavior is not specified in a DB schema, this
> should be, at least, clearly documented.

ack, I am fine to just drop this patch and keep current behaviour.


> Bets regards, Ilya Maximets.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

More information about the dev mailing list