[ovs-dev] [PATCH ovs]: lib/db-ctl-base.c: Check that --all or records argument provided
Ben Pfaff
blp at ovn.org
Fri Mar 26 00:40:00 UTC 2021
On Thu, Mar 25, 2021 at 09:18:19PM +0200, Alexey Roytman wrote:
> From: Alexey Roytman <roytman at il.ibm.com>
>
> ovn-nbctl and ovn-sbctl CLI utilities allow destroying the entire
> table or some records from the given table.
> However, either the --all option or the deleted records should be provided.
> This patch adds the test.
>
> Signed-off-by: Alexey Roytman <roytman at il.ibm.com>
>
> ---
> lib/db-ctl-base.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c
> index e95c77da2..81ade7abc 100644
> --- a/lib/db-ctl-base.c
> +++ b/lib/db-ctl-base.c
> @@ -1823,6 +1823,11 @@ cmd_destroy(struct ctl_context *ctx)
> return;
> }
>
> + if (!delete_all && ctx->argc == 2) {
> + ctl_error(ctx, "either --all or records argument should be specified");
> + return;
> + }
I can see why this is worth warning about, but a fatal error seems like
overkill. I'd use VLOG_WARN here.
I'd also add a test.
More information about the dev
mailing list