[ovs-dev] [PATCH ovn v2] Support vlan-passthru for tag=0 logical switch ports
numans at ovn.org
Fri Mar 26 04:07:44 UTC 2021
On Wed, Mar 24, 2021 at 9:22 PM Ben Pfaff <blp at ovn.org> wrote:
> On Tue, Mar 23, 2021 at 09:22:43PM -0400, Ihar Hrachyshka wrote:
> > When vlan-passthru is true for LS, for untagged localnet ports, tagged
> > VLAN traffic originating from VIFs should be passed through intact since
> > the VLAN header belongs to VIF user, not the localnet port fabric.
> > This patch adds multinode test cases to cover scenarios where packets
> > traverse through fabric layer, for both tagged and untagged (tag=0)
> > localnet ports.
> > Signed-off-by: Ihar Hrachyshka <ihrachys at redhat.com>
> Thanks for adding ddlog support. It looks correct to me.
The patch LGTM. I just have one comment. I noticed that there is
in the way ovn-northd and ovn-northd-ddlog sets the vlan-passthru in
the options column
If the logical switch's other_config:vlan-passthru is set to false i.e
ovn-nbctl set logical_switch ls other_config:vlan-passthru=false
then, ovn-northd doesn't set "vlan-passthru=false" in the options
column of port binding.
It will clear the option if it was set earlier. Whereas
ovn-northd-ddlog, sets "vlan-passthru=false".
Technically this will not have any effect on the functionality.
Although I'd suggest making it consistent.
Either make ovn-northd to set "vlan-passthru=false" or make
ovn-northd-ddlog to clear vlan-passthru.
I'm fine either way.
> dev mailing list
> dev at openvswitch.org
More information about the dev