[ovs-dev] [PATCH] github: Fix handling of python packages.

Aaron Conole aconole at redhat.com
Tue Mar 30 18:14:28 UTC 2021

Ilya Maximets <i.maximets at ovn.org> writes:

> On 3/15/21 12:53 PM, Aaron Conole wrote:
>> Ilya Maximets <i.maximets at ovn.org> writes:
>>> GitHub Actions doesn't have python locations in PATH and different
>>> runners might have different configuration for default python
>>> location and versions.  For example, on some runners python2 might
>>> be installed or not.
>>> Missing PATH causes weird situations on older branches where during
>>> one run our scripts can locate just installed flake8 and can't do
>>> that on a different run.  But this might also create other
>>> unpredictable issues on all branches.
>> This is strange.  We do an install via the package manager - is it not
>> installing to the correct PATH location?
>>> It's required to use actions/setup-python at v2 in order to have
>>> predictable version of python installed and paths correctly configured.
>>> Due to some bugs in GHA itself it doesn't set $HOME/.local/bin into
>>> PATH, so we have to do that manually for now in order to use '--user'.
>>> This might be fixed later in actions/setup-python or in base runners.
>>> We already setting it for DPDK 20.11 (I think the issue was spotted
>>> but not fully investigated).  Moving PATH updates to a separate step
>>> to make them more explicit and avaialble for all steps of the job.
>> *available
>> Do you know if GHA team has a plan to fix this?
>> It's a strange syntax, but it looks like the manual requires that we do
>> PATH updates via 'echo "..." >> $GITHUB_PATH' so, LGTM.
> Can I treat that as 'Acked-by'?

Sorry, I thought I had.

Acked-by: Aaron Conole <aconole at redhat.com>

> Bets regards, Ilya Maximets.

More information about the dev mailing list