[ovs-dev] [PATCH v2] conntrack: document NULL SNAT behavior and add a test case

[Paolo Valerio]

Eelco Chaudron <echaudro at redhat.com> writes:

> Currently, conntrack in the kernel has an undocumented feature referred
> to as NULL SNAT. Basically, when a source port collision is detected
> during the commit, the source port will be translated to an ephemeral
> port. If there is no collision, no SNAT is performed.
>
> This patchset documents this behavior and adds a self-test to verify
> it's not changing.
>
> Signed-off-by: Eelco Chaudron <echaudro at redhat.com>
> ---
> v2: Fixed NULL SNAT to only work in the -rpl state to be inline with
>     OpenShift-SDN's behavior.
>
>  lib/ovs-actions.xml              |   10 ++++++++
>  tests/system-kmod-macros.at      |    7 ++++++
>  tests/system-traffic.at          |   46 ++++++++++++++++++++++++++++++++++++++
>  tests/system-userspace-macros.at |   10 ++++++++
>  4 files changed, 73 insertions(+)

LGTM,

Acked-by: Paolo Valerio <pvalerio at redhat.com>