[ovs-dev] [PATCH RESEND ovs v3 1/4] dpif-netdev: Fix the meter buckets overflow.

Ilya Maximets i.maximets at ovn.org
Tue Mar 30 20:52:40 UTC 2021


On 3/3/21 3:46 PM, xiangxia.m.yue at gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue at gmail.com>
> 
> When setting the meter rate to 4.3+Gbps, there is an overflow, the
> meters don't work as expected.
> 
> $ ovs-ofctl -O OpenFlow13 add-meter br-int "meter=1 kbps stats bands=type=drop rate=4294968"
> 
> It was overflow when we set the rate to 4294968, because "burst_size" in
> the ofputil_meter_band is uint32_t type. This patch remove the "up"
> in the dp_meter_band struction, and introduce "rate", "burst_size" and
> "bucket" (uint64_t) to userspace datapath's meter band. This patch don't
> change the public API and structure.
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>
> ---

Thanks!  Applied to master and backported down to 2.12.

Bets regards, Ilya Maximets.


More information about the dev mailing list