[ovs-dev] [PATCH RESEND ovs v3 2/4] dpif-netdev: Refactor the buckets calculation.

Ilya Maximets i.maximets at ovn.org
Tue Mar 30 20:55:49 UTC 2021


On 3/3/21 3:46 PM, xiangxia.m.yue at gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue at gmail.com>
> 
> The way that "burst_size" was used as total buckets is
> very strange. If user set the "burst_size" too smaller while
> "rate" larger, that may affect the meter normal work.
> This patch refactor the buckets calculation, and start
> with a full buckets.
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>
> ---

Looking closely to this change, it doesn't really make much
sense without the patch #3.  So, I squashed patches 2 and 3
and applied to master.  Backported down to 2.13.

Additionally, before applying I fixed the test:
  1073. ofproto-dpif.at:2061: testing ofproto-dpif - controller with slow-path action

It was broken if the last patch in this series not applied.

Best regards, Ilya Maximets.


More information about the dev mailing list